Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin gRPC #132

Closed
18 tasks done
chalin opened this issue Mar 13, 2020 · 8 comments
Closed
18 tasks done

Kotlin gRPC #132

chalin opened this issue Mar 13, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@chalin
Copy link
Collaborator

chalin commented Mar 13, 2020

After launch:

Questions:

  • Do we want to provide some guidance in terms of writing unit tests for grpc-kotlin apps (and write an example for the Hello World app)? Cf. grpc-java/examples/example-kotlin's Unit test examples

Answered:

  • On which platforms (Windows, Linux, Mac) can grpc-kotlin be used?
  • Router guide example:
    • Stick with proto Duration type, even if it isn't used in other examples?
    • Drop/cleanup Java specific option declarations?
@chalin chalin added the enhancement New feature or request label Mar 13, 2020
@chalin chalin self-assigned this Mar 13, 2020
@chalin
Copy link
Collaborator Author

chalin commented Mar 16, 2020

@dwiner @lowasser @bshaffer @thisisnotapril - let me know if you see anything missing from the "to do" list in the opening comment of this issue.

@dwiner
Copy link

dwiner commented Mar 17, 2020

Thanks! Only thing I'd add is could we also add a link to gRPC Kotlin to the grpc/grpc README?

On whether we should track the main gRPC version numbers, I'm not sure but perhaps @lowasser or @bshaffer have some thoughts on this.

Finally, I think it makes sense to delete the grcp-java Kotlin example.

@lowasser
Copy link

Tracking the main gRPC versions makes sense to me. I think the Kotlin APIs will need to change less often in general, but version number mismatches are always confusing and painful.

@chalin
Copy link
Collaborator Author

chalin commented Mar 17, 2020

@lowasser - which platforms will be supported? Cf. https://grpc.io/about/#officially-supported-languages-and-platforms. Also, how should we express the min "Compiler / SDK" entry in that page: as "Kotlin 1.3+"?

@lowasser
Copy link

Precisely the same platforms will be supported as Java. Kotlin 1.3+ should be correct.

@lowasser
Copy link

It might be worth marking it as "Kotlin/JVM" rather than "Kotlin" generically, though? We are not yet supporting the Javascript or Native compilation backends for Kotlin.

chalin added a commit that referenced this issue Mar 17, 2020
Contributes to #132
chalin added a commit that referenced this issue Mar 18, 2020
@muxi
Copy link
Member

muxi commented Mar 18, 2020

@srini100 - office hour cc

chalin added a commit to chalin/grpc that referenced this issue Mar 23, 2020
chalin added a commit to chalin/grpc that referenced this issue Mar 23, 2020
chalin added a commit to chalin/grpc-java that referenced this issue Apr 16, 2020
@chalin
Copy link
Collaborator Author

chalin commented Apr 17, 2020

All done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants