gRPC Java blog entry: fix links and add ref to gRPC Kotlin post #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Mar 11, 2021
chalin
commented
Mar 11, 2021
jamesward
reviewed
Mar 11, 2021
chalin
force-pushed
the
chalin-blog-java-grpc-for-kotlin-2021-03-11
branch
from
5e1fd64
to
babb059
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #719
The gRPC ❤ Kotlin blog-entry's two broken links refer to https://github.com/grpc/grpc-java/tree/master/examples/example-kotlin, which was deleted via grpc/grpc-java#6936 when we introduced Kotlin gRPC (#132).
The last commit containing
example-kotlinis https://github.com/grpc/grpc-java/tree/3bd141bf184a82a2cc92c98c906141d5b32ee88e. This PR fixes the links by replacingmasterby 3bd141bf184a82a2cc92c98c906141d5b32ee88e.I've also added an alert referring readers to first Kotlin gRPC blog post.
Preview: https://deploy-preview-720--grpc-io.netlify.app/blog/kotlin-gradle-projects/