Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-java release tag to v1.31.0 #374

Closed

Conversation

ericgribkoff
Copy link
Contributor

No description provided.

@chalin
Copy link
Collaborator

chalin commented Jul 30, 2020

We had an issue earlier due to the latest release of grpc-java not being available from JCenter, see:

@chalin chalin requested a review from ejona86 July 30, 2020 16:11
@chalin
Copy link
Collaborator

chalin commented Jul 30, 2020

I see that 1.30.2 made it to JCenter (more quickly than some of us might have expected 😄): https://bintray.com/bintray/jcenter/io.grpc%3Agrpc-core

@chalin
Copy link
Collaborator

chalin commented Jul 30, 2020

I'd vote to merge this and address the Android-Java release number issue separately.

My current thinking is that we can add a note to the Android Java pages (quick start, and tutorial) to say that folks should use the latest release available from JCenter, if the advertised release hasn't shown up yet. I think that this is preferable to creation a separate "Android Java grpc-java release version" parameter, especially since we are still hoping to merge the Android-Java pages into the (regular) Java pages.

Thoughts @ejona86?

@ejona86
Copy link
Member

ejona86 commented Jul 30, 2020

@chalin, no, it still doesn't have it entirely. The problem is that the list of versions available to maven does not include it: https://jcenter.bintray.com/io/grpc/grpc-all/maven-metadata.xml . But if you look at other modules it does have 1.30.2: https://jcenter.bintray.com/io/grpc/grpc-core/maven-metadata.xml

Now, it happens that those version lists aren't always needed. They are only needed when we use version ranges. We only use version ranges when referencing grpc-core, grpc-api, and grpc-netty-shaded. So if those three have an up-to-date maven-metadata.xml, then we could probably safely use jcenter. It happens that those three do have 1.30.2.

If you look at grpc-testing-proto you can see that it isn't a simple syncing issue; it has 1.30.1 but not 1.30.0. https://jcenter.bintray.com/io/grpc/grpc-testing-proto/maven-metadata.xml

@chalin
Copy link
Collaborator

chalin commented Jul 31, 2020

See grpc/grpc-java#7276.

@srini100
Copy link
Contributor

srini100 commented Aug 5, 2020

@ejona86, should the java release process be modified to not file this version bump PR until the artifacts are available?

@ejona86
Copy link
Member

ejona86 commented Aug 5, 2020

grpc/grpc-java#7276 is the current plan. If I end up doing a patch release on Friday I will make sure that gets in before I do so. So I don't think there is any need to update the release instructions.

@ejona86 ejona86 mentioned this pull request Aug 13, 2020
@ejona86
Copy link
Member

ejona86 commented Aug 13, 2020

Closing in favor of #382

@ejona86 ejona86 closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants