Skip to content

Commit

Permalink
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_AS…
Browse files Browse the repository at this point in the history
…SERT (#36471)

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK.
These changes have been made using string replacement and regex.
Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced.
Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36471

COPYBARA_INTEGRATE_REVIEW=#36471 from tanvi-jagtap:tjagtap_src_core_lib_misc 420b545
PiperOrigin-RevId: 629629223
  • Loading branch information
tanvi-jagtap authored and Copybara-Service committed May 1, 2024
1 parent e614daf commit 760f2ae
Show file tree
Hide file tree
Showing 28 changed files with 260 additions and 227 deletions.
11 changes: 10 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1712,6 +1712,7 @@ grpc_cc_library(
"//src/core:lib/channel/call_tracer.h",
],
external_deps = [
"absl/log:check",
"absl/status",
"absl/strings",
"absl/types:optional",
Expand Down Expand Up @@ -1989,6 +1990,7 @@ grpc_cc_library(
"absl/container:inlined_vector",
"absl/functional:any_invocable",
"absl/functional:function_ref",
"absl/log:check",
"absl/meta:type_traits",
"absl/status",
"absl/status:statusor",
Expand Down Expand Up @@ -2973,6 +2975,7 @@ grpc_cc_library(
external_deps = [
"absl/flags:flag",
"absl/flags:marshalling",
"absl/log:check",
"absl/strings",
"absl/types:optional",
],
Expand Down Expand Up @@ -3008,7 +3011,10 @@ grpc_cc_library(
srcs = [
"//src/core:lib/config/core_configuration.cc",
],
external_deps = ["absl/functional:any_invocable"],
external_deps = [
"absl/functional:any_invocable",
"absl/log:check",
],
language = "c++",
public_hdrs = [
"//src/core:lib/config/core_configuration.h",
Expand Down Expand Up @@ -3205,6 +3211,7 @@ grpc_cc_library(
"//src/core:lib/address_utils/sockaddr_utils.h",
],
external_deps = [
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings",
Expand Down Expand Up @@ -3330,6 +3337,7 @@ grpc_cc_library(
"//src/core:lib/iomgr/grpc_if_nametoindex.h",
],
external_deps = [
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings",
Expand Down Expand Up @@ -3819,6 +3827,7 @@ grpc_cc_library(
external_deps = [
"absl/base:core_headers",
"absl/functional:bind_front",
"absl/log:check",
"absl/status",
"absl/status:statusor",
"absl/strings",
Expand Down
19 changes: 2 additions & 17 deletions CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 1 addition & 16 deletions build_autogenerated.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 760f2ae

Please sign in to comment.