Skip to content

Commit

Permalink
Revert "[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl loggin…
Browse files Browse the repository at this point in the history
…g - BUILD (#36607)" (#36625)

This reverts commit 1585097.

Breaks the bazel distribtests. https://source.cloud.google.com/results/invocations/da317d7c-5240-445f-8953-68a840ccc892/targets/%2F%2Ftools%2Fbazelify_tests%2Ftest:bazel_distribtest_6.5.0_buildtest/log

Closes #36625

COPYBARA_INTEGRATE_REVIEW=#36625 from drfloob:revert-36607 395191f
PiperOrigin-RevId: 633995522
  • Loading branch information
drfloob authored and Copybara-Service committed May 15, 2024
1 parent befeeba commit bc5570b
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 78 deletions.
2 changes: 0 additions & 2 deletions test/cpp/common/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ grpc_cc_test(
srcs = ["timer_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
flaky = True,
Expand All @@ -53,7 +52,6 @@ grpc_cc_test(
srcs = ["time_jump_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = [
Expand Down
27 changes: 0 additions & 27 deletions test/cpp/end2end/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ grpc_cc_library(
srcs = ["test_service_impl.cc"],
hdrs = ["test_service_impl.h"],
external_deps = [
"absl/log:log",
"gtest",
"absl/log:check",
"absl/synchronization",
Expand Down Expand Up @@ -66,7 +65,6 @@ grpc_cc_library(
hdrs = ["connection_attempt_injector.h"],
external_deps = [
"absl/log:check",
"absl/log:log",
],
deps = [
"//:grpc",
Expand Down Expand Up @@ -94,7 +92,6 @@ grpc_cc_library(
srcs = ["rls_server.cc"],
hdrs = ["rls_server.h"],
external_deps = [
"absl/log:log",
"gtest",
],
deps = [
Expand All @@ -109,7 +106,6 @@ grpc_cc_test(
srcs = ["async_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
shard_count = 10,
Expand Down Expand Up @@ -191,7 +187,6 @@ grpc_cc_binary(
srcs = ["client_crash_test_server.cc"],
external_deps = [
"absl/flags:flag",
"absl/log:log",
"gtest",
],
deps = [
Expand All @@ -212,7 +207,6 @@ grpc_cc_test(
name = "client_fork_test",
srcs = ["client_fork_test.cc"],
external_deps = [
"absl/log:log",
"absl/strings",
"gtest",
],
Expand All @@ -238,7 +232,6 @@ grpc_cc_test(
srcs = ["client_callback_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -378,7 +371,6 @@ grpc_cc_test(
grpc_cc_test(
name = "end2end_test",
size = "large",
external_deps = ["absl/log:log"],
flaky = True, # TODO(b/151704375)
shard_count = 10,
tags = [
Expand Down Expand Up @@ -456,7 +448,6 @@ grpc_cc_test(
srcs = ["hybrid_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -498,7 +489,6 @@ grpc_cc_test(
name = "mock_test",
srcs = ["mock_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -575,7 +565,6 @@ grpc_cc_test(
srcs = ["rls_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"absl/types:optional",
"gtest",
],
Expand Down Expand Up @@ -610,7 +599,6 @@ grpc_cc_test(
srcs = ["service_config_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -711,7 +699,6 @@ grpc_cc_test(
],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = [
Expand All @@ -738,7 +725,6 @@ grpc_cc_binary(
external_deps = [
"absl/flags:flag",
"absl/log:check",
"absl/log:log",
"gtest",
],
deps = [
Expand Down Expand Up @@ -778,7 +764,6 @@ grpc_cc_test(
name = "server_load_reporting_end2end_test",
srcs = ["server_load_reporting_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
tags = [
Expand All @@ -797,7 +782,6 @@ grpc_cc_test(
name = "flaky_network_test",
srcs = ["flaky_network_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
tags = [
Expand Down Expand Up @@ -825,7 +809,6 @@ grpc_cc_test(
srcs = ["shutdown_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand All @@ -845,7 +828,6 @@ grpc_cc_test(
name = "streaming_throughput_test",
srcs = ["streaming_throughput_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
tags = [
Expand All @@ -869,7 +851,6 @@ grpc_cc_test(
size = "large",
srcs = ["thread_stress_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
shard_count = 5,
Expand All @@ -894,7 +875,6 @@ grpc_cc_test(
srcs = ["cfstream_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = [
Expand Down Expand Up @@ -924,7 +904,6 @@ grpc_cc_test(
srcs = ["message_allocator_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand All @@ -946,7 +925,6 @@ grpc_cc_test(
srcs = ["context_allocator_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand All @@ -968,7 +946,6 @@ grpc_cc_test(
srcs = ["port_sharing_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -1058,7 +1035,6 @@ grpc_cc_test(
name = "orca_service_end2end_test",
srcs = ["orca_service_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
tags = ["cpp_end2end_test"],
Expand Down Expand Up @@ -1104,7 +1080,6 @@ grpc_cc_test(
"//src/core/tsi/test_creds:server1.pem",
],
external_deps = [
"absl/log:log",
"gtest",
],
tags = ["ssl_credentials_test"],
Expand All @@ -1131,7 +1106,6 @@ grpc_cc_test(
"//src/core/tsi/test_creds:server1.pem",
],
external_deps = [
"absl/log:log",
"gtest",
],
tags = ["tls_credentials_test"],
Expand Down Expand Up @@ -1160,7 +1134,6 @@ grpc_cc_test(
],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
tags = ["crl_provider_test"],
Expand Down
9 changes: 0 additions & 9 deletions test/cpp/end2end/xds/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ grpc_cc_library(
hdrs = ["xds_end2end_test_lib.h"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
deps = [
Expand Down Expand Up @@ -116,7 +115,6 @@ grpc_cc_test(
],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
flaky = True, # TODO(b/144705388)
Expand Down Expand Up @@ -164,7 +162,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_cluster_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
flaky = True, # TODO(b/144705388)
Expand Down Expand Up @@ -193,7 +190,6 @@ grpc_cc_test(
srcs = ["xds_cluster_type_end2end_test.cc"],
external_deps = [
"absl/log:check",
"absl/log:log",
"gtest",
],
flaky = True, # TODO(b/144705388)
Expand Down Expand Up @@ -221,7 +217,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_core_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
flaky = True,
Expand All @@ -248,7 +243,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_csds_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
linkstatic = True, # Fixes dyld error on MacOS
Expand Down Expand Up @@ -330,7 +324,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_wrr_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
linkstatic = True, # Fixes dyld error on MacOS
Expand Down Expand Up @@ -417,7 +410,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_routing_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
flaky = True, # TODO(b/144705388)
Expand Down Expand Up @@ -466,7 +458,6 @@ grpc_cc_test(
size = "large",
srcs = ["xds_override_host_end2end_test.cc"],
external_deps = [
"absl/log:log",
"gtest",
],
linkstatic = True, # Fixes dyld error on MacOS
Expand Down
1 change: 0 additions & 1 deletion test/cpp/ext/filters/logging/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ grpc_cc_library(
srcs = ["library.cc"],
hdrs = ["library.h"],
external_deps = [
"absl/log:log",
"gtest",
],
language = "C++",
Expand Down

0 comments on commit bc5570b

Please sign in to comment.