New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re2 dependency fails to build using latest CMake #36358
Comments
Once there's a new release of RE2 any objections updating the dependency version in this repo to the latest version? I will create a PR. I'll check for any breaking changes. It's been over two years since RE2 was updated. |
It seems @veblush is already working on updating re2. Esun, can you just use the next upcoming release please? |
There is a new re2 release with the fix included https://github.com/google/re2/releases/tag/2024-05-01. @veblush you want me to create PR or you got it? |
@xanather It'd be great if you can make a PR for this one. |
What version of gRPC and what language are you using?
Latest master branch
What operating system (Linux, Windows,...) and version?
All OS's affected
What runtime / compiler are you using (e.g. python version or version of gcc)
CMake 3.29.1
What did you do?
Attempt to build gRPC including all dependencies using package mode using the third_party directory and recursive git submodules
What did you expect to see?
Successful build
What did you see instead?
CMake Error at /home/runner/grpc/lib/cmake/re2/re2Config.cmake:15 (message):
File or directory /include referenced by variable re2_INCLUDE_DIR does not
exist !
Call Stack (most recent call first):
Suggested changes
This commit fixes compiling with latest CMake: google/re2@9ebe4a2
Need to create a update in this repo similar to this one: 3d104df (maybe after RE2 does next full release)?
I was going to create a PR myself but there's no proper release of RE2 with that fix in just yet so I'm creating an issue to track the problem.
Thanks
The text was updated successfully, but these errors were encountered: