Upgrade re2 to 2024-04-01 (Latest CMake Build Fix) #36558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
Anything I can do to get this merged? |
|
This is such a simple commit that'll fix my build pipeline. I can't choose what version of CMake I am using on GitHub hosted runners so can this please be merged? |
yashykt
approved these changes
May 21, 2024
veblush
added
the
release notes: no
|
Can we get this landed on 1.64.1? This should also fix the issue that re2.pc is missing when build and install grpc and its dependencies using cmake. |
|
There are many test failures. You need to resolve them to get this merged. |
|
Half the tests I don't even have permission to view. Anyway, it seems RE2 isn't properly picking up ABSL targets for some build targets |
|
I might spend some time trying to fix this if I get permissions to view and run the GCP tests myself so I can sort it in one sitting otherwise its not my problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36358 (comment)