Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inhibit warnings caused by Protobuf #15104

Merged
merged 1 commit into from Apr 18, 2018
Merged

Inhibit warnings caused by Protobuf #15104

merged 1 commit into from Apr 18, 2018

Conversation

muxi
Copy link
Member

@muxi muxi commented Apr 18, 2018

Some protobuf related warnings are causing build issue on objc-tests. This PR inhibits these warnings as they are not immediately solvable. See protocolbuffers/protobuf#3218.

@muxi muxi added the lang/ObjC label Apr 18, 2018
@muxi muxi requested a review from makdharma April 18, 2018 16:43
@muxi
Copy link
Member Author

muxi commented Apr 18, 2018

To fix MacOS test failures. Other tests unrelated.

@muxi muxi merged commit 8cd9f91 into master Apr 18, 2018
@muxi muxi deleted the inhibit-tests-warning branch April 18, 2018 22:20
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
@lock lock bot unassigned makdharma Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@makdharma makdharma makdharma approved these changes

Assignees
No one assigned
Labels
lang/ObjC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@muxi @makdharma