Cronet fixes #20464
Merged
Cronet fixes #20464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmstar
commented
Oct 3, 2019
•
rmstar
commented
- Fixed bug in cronet_transport where completed ops were not removed from storage
- Don't collect cronet netlog. It's slow and file size can be huge
- Cronet Perf tests: Added 1 KB unary RPC test case
- Reduce number of messages from 10000->1000 to reduce test run time.
muxi
approved these changes
Oct 3, 2019
| @@ -30,6 +30,5 @@ void configureCronet(void) { | |||
| inDomains:NSUserDomainMask] lastObject]; | |||
| NSLog(@"Documents directory: %@", url); | |||
| [Cronet start]; | |||
| [Cronet startNetLogToFile:@"cronet_netlog.json" logBytes:YES]; | |||
There was a problem hiding this comment.
Instead of removing it, maybe make this configurable? Sometimes netlog is useful.
| @@ -181,7 +181,7 @@ - (void)testPingPongRPCWithV2API { | |||
| [self pingPongV2APIWithRequest:request numMessages:1000 options:options]; | |||
|
|
|||
| [self measureBlock:^{ | |||
| [self pingPongV2APIWithRequest:request numMessages:10000 options:options]; | |||
| [self pingPongV2APIWithRequest:request numMessages:1000 options:options]; | |||
There was a problem hiding this comment.
Could you explain a bit why we are reducing the number? Maybe in the PR description. For record.
There was a problem hiding this comment.
It's to reduce test run time. Takes too long with 10k messages, and we don't really get any additional benefit with more messages. I've updated the PR description.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.