Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra kokoro build info to Win RBE runs #20488

Merged
merged 1 commit into from Oct 4, 2019

Conversation

jtattermusch
Copy link
Contributor

Turns out using the --workspace_status_command=tools/remote_build/workspace_status_kokoro.sh flag doesn't work on windows.
According to bazel docs:
The flag's value must be a path to a native program. On Linux/macOS this may be any executable. On Windows this must be a native binary, typically an ".exe", ".bat", or a ".cmd" file.

@jtattermusch
Copy link
Contributor Author

@jtattermusch jtattermusch added lang/c++ release notes: no Indicates if PR should not be in release notes labels Oct 4, 2019
@veblush veblush self-requested a review October 4, 2019 15:22
Copy link
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, LGTM.

@jtattermusch
Copy link
Contributor Author

Known failures:
#20471

@jtattermusch jtattermusch merged commit 3fd325a into grpc:master Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/c++ release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants