Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update grpc protoc plugin to be compliant of proto3 field presence" #23089

Merged
merged 1 commit into from May 29, 2020
Merged

Revert "Update grpc protoc plugin to be compliant of proto3 field presence" #23089

merged 1 commit into from May 29, 2020

Conversation

karthikravis
Copy link
Contributor

@karthikravis karthikravis added the release notes: no Indicates if PR should not be in release notes label May 29, 2020
stanley-cheung
stanley-cheung approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@stanley-cheung stanley-cheung left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a side note, just checked with the protobuf team: it's internal that's wrong. Internal needs to have uint64_t. So I will roll this forward when internal protobuf has been updated.

@karthikravis
Copy link
Contributor Author

This is a revert. So ignoring test failures. Merging.

@karthikravis karthikravis merged commit 2725ae4 into master May 29, 2020
@stanley-cheung stanley-cheung mentioned this pull request May 29, 2020
Merged
@stanley-cheung stanley-cheung deleted the revert-22998-proto3-presence-protoc-plugin branch May 29, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

@gnossen gnossen Awaiting requested review from gnossen gnossen is a code owner

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@veblush veblush Awaiting requested review from veblush veblush is a code owner

Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karthikravis @stanley-cheung