Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade protobuf dependency to 3.12.4. #23841

Closed
wants to merge 1 commit into from
Closed

Upgrade protobuf dependency to 3.12.4. #23841

wants to merge 1 commit into from

Conversation

markdroth
Copy link
Member

No description provided.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Aug 14, 2020
@stanley-cheung
Copy link
Contributor

Any particular reason to move to 3.12.4? There seems to be not much added since 3.12.2, which we are currently at. See https://github.com/protocolbuffers/protobuf/commits/3.12.x. There seems to be just one Objective-C fix since 3.12.2.

Protobuf team did just release 3.13.0 today (which was earlier called 4.0.0-rc). There seems to be a lot more changes there. If we are to update the protobuf dependency, should we consider moving directly to 3.13.0?

@JamesNK
Copy link
Member

JamesNK commented Aug 15, 2020

#23485 is waiting on 3.13.0

@jtattermusch jtattermusch mentioned this pull request Aug 17, 2020
Merged
@jtattermusch
Copy link
Contributor

I created a PR for upgrade to 3.13.0 #23855.

@markdroth
Copy link
Member Author

I was just doing this as part of the normal preparations for the next gRPC release. When I looked at the protobuf repo, 3.12.4 was the latest version. I'm fine with upgrading to 3.13 instead, as long as there are no problems with it.

@markdroth markdroth closed this Aug 18, 2020
@markdroth markdroth deleted the protobuf_upgrade branch August 18, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srini100 srini100 Awaiting requested review from srini100

@gnossen gnossen Awaiting requested review from gnossen gnossen is a code owner

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@veblush veblush Awaiting requested review from veblush veblush is a code owner

Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markdroth @stanley-cheung @JamesNK @jtattermusch