Switch to using protobuf's helper for the file's prefix. #26605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for protobuf ObjC support for using the proto package to define the prefix for the file (protocolbuffers/protobuf#8760). Once protobuf cuts a release, it likely makes sense to support the same generator options that the objc generator does, but for now the environment variable support can used to enable this when building from recent sources.
|
|
veblush
added
release notes: no
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
This adds support for protobuf ObjC support for using the proto package to define the prefix for the file (protocolbuffers/protobuf#8760). Once protobuf cuts a release, it likely makes sense to support the same generator options that the objc generator does, but for now the environment variable support can used to enable this when building from recent sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for protobuf ObjC support for using the proto package to
define the prefix for the file (protocolbuffers/protobuf#8760).
Once protobuf cuts a release, it likely makes sense to support the same
generator options that the objc generator does, but for now the environment
variable support can used to enable this when building from recent sources.
@veblush