Fix deprecated inheritance of std::iterator #28212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
|
Dropping a note here that we have run into the same issue, and we're going to adopt this PR in a test build. I'd appreciate a heads up if either the author or the maintainers have decided on a different solution. |
ctiller
added
the
release notes: no
|
This seems like a reasonable change. Going to run it through tests and then just merge. |
ctiller
approved these changes
Apr 22, 2022
|
We are using this patch in productive code and experienced no problem so far. 😉 |
|
Thanks for merging! :) |
copybara-service
bot
added
the
imported
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 16, 2022
Update gRPC to pull in grpc/grpc#28212 to unblock upgrading libc++ in Chromium. Bug: 1273285 Change-Id: I1fb483fadc9bd9d1406fbdd22f5b9263e5b6d014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644998 Reviewed-by: Yue Li <updowndota@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Alan Zhao <ayzhao@google.com> Cr-Commit-Position: refs/heads/main@{#1003976}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Update gRPC to pull in grpc/grpc#28212 to unblock upgrading libc++ in Chromium. Bug: 1273285 Change-Id: I1fb483fadc9bd9d1406fbdd22f5b9263e5b6d014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644998 Reviewed-by: Yue Li <updowndota@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Alan Zhao <ayzhao@google.com> Cr-Commit-Position: refs/heads/main@{#1003976} NOKEYCHECK=True GitOrigin-RevId: 7c5086062c29c919152a4a0e6e2611f6276a006e
zcbenz
pushed a commit
to yue/abseil-cpp
that referenced
this pull request
Feb 20, 2023
Update gRPC to pull in grpc/grpc#28212 to unblock upgrading libc++ in Chromium. Bug: 1273285 Change-Id: I1fb483fadc9bd9d1406fbdd22f5b9263e5b6d014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644998 Reviewed-by: Yue Li <updowndota@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Alan Zhao <ayzhao@google.com> Cr-Commit-Position: refs/heads/main@{#1003976} NOKEYCHECK=True GitOrigin-RevId: 7c5086062c29c919152a4a0e6e2611f6276a006e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of "-Wdeprecated-declarations" (seen with clang 13) in the way it was suggested by #25125.
The approach has been slightly adapted to be more like protocolbuffers/protobuf#8741 - mainly by using "using" instead of "typedef".
@nicolasnoble