Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

priority and ring_hash LBs: fix interactions when using ring_hash under priority #29332

Merged
merged 29 commits into from Apr 15, 2022
Merged

priority and ring_hash LBs: fix interactions when using ring_hash under priority #29332

merged 29 commits into from Apr 15, 2022

Commits on Apr 6, 2022

  1. refactor connection delay injection from client_lb_end2end_test

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0c6ccf1 View commit details
    Browse the repository at this point in the history

  2. fix build

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    96119c0 View commit details
    Browse the repository at this point in the history

  3. fix build on older compilers

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6462019 View commit details
    Browse the repository at this point in the history

  4. clang-format

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c9ea149 View commit details
    Browse the repository at this point in the history

  5. buildifier

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    58378ae View commit details
    Browse the repository at this point in the history

  6. a bit of code cleanup

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    033c31e View commit details
    Browse the repository at this point in the history

  7. start failover time whenever the child reports CONNECTING, and don't … 

    …cancel when deactivating
    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f80fcac View commit details
    Browse the repository at this point in the history

  8. clang-format

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    44eaf30 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into priority_lb_fix

    @markdroth
    markdroth committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d1588cb View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. rewrite test

    @markdroth
    markdroth committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    2467440 View commit details
    Browse the repository at this point in the history

  2. simplify logic in priority policy

    @markdroth
    markdroth committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    75e26c2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into priority_lb_fix

    @markdroth
    markdroth committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    73ef75f View commit details
    Browse the repository at this point in the history

  4. clang-format

    @markdroth
    markdroth committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    830f049 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. switch to using a bit to indicate child healthiness

    @markdroth
    markdroth committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b245c89 View commit details
    Browse the repository at this point in the history

  2. fix reversed comment

    @markdroth
    markdroth committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    eb103bf View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. more changes in priority and ring_hash. 

    priority:
- go back to starting failover timer upon CONNECTING, but only if seen
  READY or IDLE more recently than TRANSIENT_FAILURE

ring_hash:
- don't flap back and forth between IDLE and CONNECTING; once we go
  CONNECTING, we stay there until either TF or READY
- after the first subchannel goes TF, we proactively start another
  subchannel connecting, just like we do after a second subchannel
  reports TF, to ensure that we don't stay in CONNECTING indefinitely if
  we aren't getting any new picks
- always return ring hash's picker, regardless of connectivity state
- update the subchannel connectivity state seen by the picker upon
  subchannel list creation
- start proactive subchannel connection attempt upon subchannel list
  creation if needed
    @markdroth
    markdroth committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    6c37cad View commit details
    Browse the repository at this point in the history

  2. ring_hash: fix connectivity state seen by aggregation and picker

    @markdroth
    markdroth committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    0c9f246 View commit details
    Browse the repository at this point in the history

  3. fix obiwan error

    @markdroth
    markdroth committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    babfae8 View commit details
    Browse the repository at this point in the history

  4. swap the order of ring_hash aggregation rules 3 and 4

    @markdroth
    markdroth committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    636daa6 View commit details
    Browse the repository at this point in the history

  5. restore original test

    @markdroth
    markdroth committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    aec7770 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. refactor connection injector QueuedAttempt code

    @markdroth
    markdroth committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    ca1be91 View commit details
    Browse the repository at this point in the history

  2. add test showing that ring_hash will continue connecting without picks

    @markdroth
    markdroth committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    9a985a6 View commit details
    Browse the repository at this point in the history

  3. clang-format

    @markdroth
    markdroth committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    0014d11 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into priority_lb_fix

    @markdroth
    markdroth committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    cc25c07 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. don't actually need seen_failure_since_ready_ anymore

    @markdroth
    markdroth committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    93dbc5a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into priority_lb_fix

    @markdroth
    markdroth committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    79127fc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. fix TSAN problem

    @markdroth
    markdroth committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    ba54014 View commit details
    Browse the repository at this point in the history

  2. address code review comments

    @markdroth
    markdroth committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4f8fcd9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into priority_lb_fix

    @markdroth
    markdroth committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    9c99a8a View commit details
    Browse the repository at this point in the history