Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Publish xds-protos as part of the standard package pipeline #33797

Merged
merged 22 commits into from
Jul 25, 2023

Conversation

gnossen
Copy link
Contributor

@gnossen gnossen commented Jul 20, 2023

This PR:

  • Fixes the xds-protos Python package, which was broken when the udpa submodule was removed
    • This required re-adding the protoc-gen-validate submodule
  • Adds non-Bazel tests for xds-protos and all of its dependent packages
  • Versions xds-protos the same way as the rest of the Python packages
  • Fixes Python 3.11 support in run_tests.py, which is necessary for the testing mentioned above

CC @sergiitk You won't be able to consume this in the interop tests until it makes it into a release. I'm thinking I'll want to backport this to the 1.57.x branch to make that happen faster.

CC @drfloob to inform him about the likely backport.

@gnossen gnossen added the release notes: yes Indicates if PR needs to be in release notes label Jul 21, 2023
@gnossen gnossen changed the title Standardize xds_protos package [packaging] Publish xds-protos as part of the standard package pipeline Jul 21, 2023
@gnossen gnossen marked this pull request as ready for review July 21, 2023 21:46
@gnossen gnossen requested a review from sergiitk July 21, 2023 21:46
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits and some typo fixes

src/python/grpcio_csds/setup.py Outdated Show resolved Hide resolved
templates/tools/dockerfile/compile_python_311.include Outdated Show resolved Hide resolved
tools/distrib/python/xds_protos/build.py Outdated Show resolved Hide resolved
tools/run_tests/run_tests.py Outdated Show resolved Hide resolved
tools/run_tests/run_tests.py Outdated Show resolved Hide resolved
@gnossen gnossen merged commit 498fc99 into grpc:master Jul 25, 2023
64 of 65 checks passed
@gnossen
Copy link
Contributor Author

gnossen commented Jul 25, 2023

CC @XuanWang-Amos

@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jul 26, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
…ne (grpc#33797)

This PR:

- Fixes the xds-protos Python package, which was broken when the `udpa`
submodule was removed
  - This required re-adding the protoc-gen-validate submodule
- Adds non-Bazel tests for xds-protos and all of its dependent packages
- Versions xds-protos the same way as the rest of the Python packages
- Fixes Python 3.11 support in `run_tests.py`, which is necessary for
the testing mentioned above


CC @sergiitk You won't be able to consume this in the interop tests
until it makes it into a release. I'm thinking I'll want to backport
this to the 1.57.x branch to make that happen faster.

CC @drfloob to inform him about the likely backport.
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
…ne (grpc#33797)

This PR:

- Fixes the xds-protos Python package, which was broken when the `udpa`
submodule was removed
  - This required re-adding the protoc-gen-validate submodule
- Adds non-Bazel tests for xds-protos and all of its dependent packages
- Versions xds-protos the same way as the rest of the Python packages
- Fixes Python 3.11 support in `run_tests.py`, which is necessary for
the testing mentioned above


CC @sergiitk You won't be able to consume this in the interop tests
until it makes it into a release. I'm thinking I'll want to backport
this to the 1.57.x branch to make that happen faster.

CC @drfloob to inform him about the likely backport.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/Python per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants