-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packaging] Publish xds-protos as part of the standard package pipeline #33797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Jul 20, 2023
gnossen
added
the
release notes: yes
Indicates if PR needs to be in release notes
label
Jul 21, 2023
gnossen
changed the title
Standardize xds_protos package
[packaging] Publish xds-protos as part of the standard package pipeline
Jul 21, 2023
sergiitk
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits and some typo fixes
templates/tools/distrib/python/xds_protos/grpc_version.py.template
Outdated
Show resolved
Hide resolved
sergiitk
approved these changes
Jul 24, 2023
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Jul 26, 2023
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…ne (grpc#33797) This PR: - Fixes the xds-protos Python package, which was broken when the `udpa` submodule was removed - This required re-adding the protoc-gen-validate submodule - Adds non-Bazel tests for xds-protos and all of its dependent packages - Versions xds-protos the same way as the rest of the Python packages - Fixes Python 3.11 support in `run_tests.py`, which is necessary for the testing mentioned above CC @sergiitk You won't be able to consume this in the interop tests until it makes it into a release. I'm thinking I'll want to backport this to the 1.57.x branch to make that happen faster. CC @drfloob to inform him about the likely backport.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…ne (grpc#33797) This PR: - Fixes the xds-protos Python package, which was broken when the `udpa` submodule was removed - This required re-adding the protoc-gen-validate submodule - Adds non-Bazel tests for xds-protos and all of its dependent packages - Versions xds-protos the same way as the rest of the Python packages - Fixes Python 3.11 support in `run_tests.py`, which is necessary for the testing mentioned above CC @sergiitk You won't be able to consume this in the interop tests until it makes it into a release. I'm thinking I'll want to backport this to the 1.57.x branch to make that happen faster. CC @drfloob to inform him about the likely backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
imported
Specifies if the PR has been imported to the internal repository
lang/Python
per-call-memory/neutral
per-channel-memory/neutral
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
udpa
submodule was removedrun_tests.py
, which is necessary for the testing mentioned aboveCC @sergiitk You won't be able to consume this in the interop tests until it makes it into a release. I'm thinking I'll want to backport this to the 1.57.x branch to make that happen faster.
CC @drfloob to inform him about the likely backport.