[ruby] Fix linking errors on x86-darwin #34134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
changed the title
stanhu
force-pushed
the
sh-x86-darwin-build-errors
branch
from
47605ba
to
660bed6
Compare
grpc#33538 added `-weak_framework CoreFoundation` in `DLDFLAGS` for only `arm64-darwin` builds, but the issue reported in grpc#33483 can also happen on `x86-darwin` builds. This can happen if: 1. The Ruby interpreter is compiled without `-Wl,-undefined,dynamic_lookup`. 2. This happens if the Ruby interpreter is built with XCode 14.0 to 14.2 (https://bugs.ruby-lang.org/issues/19005). Simplify the logic and always include `-weak_framework CoreFoundation` for macOS builds.
stanhu
force-pushed
the
sh-x86-darwin-build-errors
branch
from
660bed6
to
ebf8cbe
Compare
alto-ruby
approved these changes
Aug 23, 2023
|
@apolcyn I think this PR makes sense and I have approved it, can you also take a look? |
alto-ruby
approved these changes
Aug 29, 2023
alto-ruby
added
the
release notes: yes
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33538 added
-weak_framework CoreFoundationinDLDFLAGSfor onlyarm64-darwinbuilds, but the issue reported in #33483 can also happen onx86-darwinbuilds. This can happen if:-Wl,-undefined,dynamic_lookup.Simplify the logic and always include
-weak_framework CoreFoundationfor macOS builds.