Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Add gRPC_USE_SYSTEMD option #34384

Closed
wants to merge 1 commit into from
Closed

[CMake] Add gRPC_USE_SYSTEMD option #34384

wants to merge 1 commit into from

Conversation

kirpichik
Copy link
Contributor

@kirpichik kirpichik commented Sep 16, 2023 •
edited

Issue #34304

Allows to disable systemd support,
as well as linking with libsystemd,
when it is not required.

The option has three possible values:
AUTO - Default, Will try to find libsystemd. If found, systemd support will be enabled.
ON - Enable systemd support. Build will fail if libsystemd is not found.
OFF - Disable systemd support.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kirpichik / name: Kirill (96f5f4b)

@kirpichik kirpichik mentioned this pull request Sep 16, 2023
Closed
@kirpichik
Copy link
Contributor Author

Issue: #34304

@markdroth markdroth assigned veblush and unassigned markdroth Sep 19, 2023
@yashykt
Copy link
Member

yashykt commented Oct 24, 2023

Please sign the CLA

@kirpichik
Copy link
Contributor Author

Signed.

@grpc-bot
Copy link

More than 30 days have passed since label "disposition/requires reporter action" was added. Closing this issue. Please feel free to re-open/create a new issue if this is still relevant.

@grpc-bot grpc-bot closed this Nov 24, 2023
@kirpichik
Copy link
Contributor Author

@yashykt @veblush please take a look

@nxrighthere
Copy link

Thank you for the patch. It resolves our issues in the cross-compilation build toolchain.

@AndreyMlashkin
Copy link

Was it merged?...

@kirpichik
Copy link
Contributor Author

@AndreyMlashkin No, the bot closed this PR due to the inactivity of reviewers and I do not have the rights to reopen it. Not sure how else I can ping maintainers.

@drfloob drfloob reopened this Jan 30, 2024
@drfloob drfloob requested a review from veblush as a code owner January 30, 2024 18:29
@veblush
Copy link
Contributor

veblush commented Jan 30, 2024

I'd prefer this option looks like; (mostly the same with different names)

  • AUTO - Default, Will try to find libsystemd. If found, systemd support will be enabled.
  • ON - Enable systemd support. It will fail if systemd is not found.
  • OFF - Disable systemd support.

@kirpichik
[CMake] Add gRPC_USE_SYSTEMD option
96f5f4b 
Allows to disable systemd support,
as well as linking with libsystemd,
when it is not required.

The option has three possible values:
AUTO - Default, Will try to find libsystemd.
  If found, systemd support will be enabled.
ON - Enable systemd support. Build will fail
  if libsystemd is not found.
OFF - Disable systemd support.
@kirpichik
Copy link
Contributor Author

@veblush updated according to your preferences.

veblush
veblush approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@veblush veblush added the release notes: no Indicates if PR should not be in release notes label Mar 6, 2024
@veblush veblush added area/build release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Mar 6, 2024
@kirpichik
Copy link
Contributor Author

@veblush @yashykt Thanks for the review! When can we expect to merge this PR? It seems someone from your team should press the button...

@yashykt
Copy link
Member

yashykt commented Apr 2, 2024

yeah, sorry for the delay. Not sure what happened here. Let me see why this got stuck.

@copybara-service copybara-service bot closed this in 5c3400e Apr 2, 2024
copybara-service bot pushed a commit that referenced this pull request Apr 2, 2024
@markdroth
[export] [endpoint] Remove grpc_endpoint_shutdown().
1162df3 
This gives grpc_endpoint the same destruction-is-shutdown semantic as
EventEngine::Endpoint, which will make the migration easier.
COPYBARA_INTEGRATE_REVIEW=#34384 from kirpichik:cmake-use-systemd-option 96f5f4b
FUTURE_COPYBARA_INTEGRATE_REVIEW=#34384 from kirpichik:cmake-use-systemd-option 96f5f4b

----
DO NOT SUBMIT. This PR is for testing purposes only. [cl/620101818](http://cl/620101818) [cl/621274356](http://cl/621274356)

PiperOrigin-RevId: 620101818
@copybara-service copybara-service bot mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veblush veblush veblush approved these changes

@yashykt yashykt yashykt approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

Assignees

@veblush veblush

@yashykt yashykt

Labels
area/build bloat/none lang/core per-call-memory/increase per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@kirpichik @yashykt @grpc-bot @nxrighthere @AndreyMlashkin @veblush @drfloob @grpc-kokoro @markdroth