Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BoringSSL] Update third_party/boringssl-with-bazel #35768

Closed
wants to merge 8 commits into from

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Jan 31, 2024

Change was created by the release automation script. See go/grpc-release.

On top of changes made by the script, setup.py had to be updated to have /std:c11 option for MSVC to use c11 features for boringssl.

@veblush veblush force-pushed the update_boringssl_202401301430 branch from 25bfe3b to 95adc76 Compare January 31, 2024 18:10
@veblush
Copy link
Contributor Author

veblush commented Jan 31, 2024

Distribution Test Python MacOS failed with the following error (log)

clang: error: unable to execute command: Segmentation fault: 11
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin21.6.0

@veblush veblush marked this pull request as ready for review January 31, 2024 22:24
@veblush veblush requested a review from gnossen as a code owner January 31, 2024 22:24
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to setup.py changes.

@veblush veblush force-pushed the update_boringssl_202401301430 branch from 2b2083e to 67bc4a1 Compare February 1, 2024 04:15
@veblush
Copy link
Contributor Author

veblush commented Feb 1, 2024

Distribution Test Python MacOS failed with the following error (log)

clang: error: unable to execute command: Segmentation fault: 11
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin21.6.0

This turned out to be caused by OOM so I reduce the -j value from 4 to 2 to workaround it.

@Jan-E
Copy link

Jan-E commented Apr 26, 2024

@veblush To make sure c11 is used with MSVC you could also add that to config.w32. Something like

 if (PHP_GRPC != "no") {
+ 
+  ADD_FLAG("CFLAGS_GRPC", " /std:c11 ");

This in reaction to what was there in the 1.61.0 release
https://github.com/google/boringssl/blob/2ff4b968a7e0cfee66d9f151cb95635b43dc1d5b/src/crypto/internal.h#L142
// TODO(davidben): In MSVC 2019 16.8 or higher (_MSC_VER >= 1928),
// |STDC_VERSION| will be 201112 when passed /std:c11 and unset otherwise.
// C11 alignas and alignof are only implemented in C11 mode. Can we mandate C11
// mode for those versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants