Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] Fix CSM Observability for trailers-only response #36413

Closed
wants to merge 9 commits into from

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Apr 20, 2024

Before this change, on a trailers-only response, Metadata Exchange needed by CSM would just be dropped, and hence CSM labels would not be seen.

Changes -

  • OTel call attempt tracer populates labels from trailers if it's a trailers-only response.
  • HTTP2 layer propagates the Metadata Exchange field from headers to trailers for trailers-only responses.
  • Add a test to make sure that retries continue to work when Metadata Exchange is enabled and a trailers-only response is sent. (This verifies that a trailers-only response remains a trailers-only response.)

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Apr 26, 2024
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Please make sure @ctiller signs off before merging.

@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels May 1, 2024
@copybara-service copybara-service bot closed this in 108ee94 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants