[export] #36425
Open
[export] #36425
+103
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/increase
per-channel-memory/neutral
bloat/none
labels
ctiller
reviewed
Apr 24, 2024
src/core/lib/promise/mpsc.h
Outdated
| return [this]() -> Poll<std::vector<T>> { | ||
| if (buffer_it_ == buffer_.end()) { | ||
| if (center_->PollReceiveBatch(buffer_)) { | ||
| buffer_it_ = buffer_.begin(); |
There was a problem hiding this comment.
I think this could be return std::move(buffer_); -- avoiding the loop & move below
copybara-service
bot
force-pushed
the
test_627143927
branch
from
f85c9f8
to
1193644
Compare
Batch pending rpcs in client and server side before sending them down to tcp. If multiple rpcs get queued up into chaotic good, it should send them out over one tcp endpoint write. ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/627143927](http://cl/627143927) PiperOrigin-RevId: 627143927
copybara-service
bot
force-pushed
the
test_627143927
branch
from
1193644
to
c5a300e
Compare
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[export]
Batch pending rpcs in client and server side before sending them down to tcp. If multiple rpcs get queued up into chaotic good, it should send them out over one tcp endpoint write.
DO NOT SUBMIT. This PR is for testing purposes only. cl/627143927