Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting and default_engine_factory for visionOS. #36429

Closed
wants to merge 4 commits into from

Conversation

tfg4
Copy link

@tfg4 tfg4 commented Apr 23, 2024

Add config setting and default_engine_factory for visionOS.

Copy link

linux-foundation-easycla bot commented Apr 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@veblush veblush added release notes: no Indicates if PR should not be in release notes platform/iOS area/build labels Apr 23, 2024
@veblush veblush assigned sampajano and unassigned veblush Apr 23, 2024
@veblush
Copy link
Contributor

veblush commented Apr 23, 2024

@sampajano Would you look at this? If we want to add new visionos build configuration, do we need to do for other builds such as podspec?

@sampajano
Copy link
Contributor

@veblush Thank you for forwarding it to me!!


@HannahShiSFB Hi Hannah, could you help take a look at this request, and check if there's other places that we need to match it like mentioned above? Thanks!!

@sampajano
Copy link
Contributor

@tfg4 Hi!

We have worked on another PR for adding visionOS support to grpc here:
#36476

That PR has all accompanying podspec change too, so i think we will use that one instead of this PR.

Thanks for your contribution!

@sampajano sampajano closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants