[BoringSSL] Update third_party/boringssl-with-bazel #36435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
added
the
release notes: yes
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
|
@HannahShiSFB Hi Hannah could you help take a look at what are some potential causes for those iOS failures? I know "Basic Tests ObjC iOS" is flaky ~5% of the time so it could just be that. But the "Basic Tests ObjC Examples" failures aren't known to be flaky. |
| @@ -70,7 +70,7 @@ | |||
|
|
|||
| Pod::Spec.new do |s| | |||
| s.name = 'BoringSSL-GRPC' | |||
| version = '0.0.33' | |||
| version = '0.0.34' | |||
| s.version = version | |||
| s.summary = 'BoringSSL is a fork of OpenSSL that is designed to meet Google\'s needs.' | |||
| # Adapted from the homepage: | |||
There was a problem hiding this comment.
Can you try add the include files pattern in line 152 to include sub directories?
Add something like 'src/include/openssl/**/*.h'
There was a problem hiding this comment.
That fixed that, but looks like there are other issues now :(
There was a problem hiding this comment.
Looks like path to err_data.c changed, can you update it accordingly?
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
veblush
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change was created by the release automation script. See go/grpc-release.