New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[generic API] separate callback from cq in generic stub/service #36447
Open
yousukseung
wants to merge
2
commits into
grpc:master
Choose a base branch
from
yousukseung:generic-stub-service-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[generic API] separate callback from cq in generic stub/service #36447
yousukseung
wants to merge
2
commits into
grpc:master
from
yousukseung:generic-stub-service-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousukseung
added
the
release notes: no
Indicates if PR should not be in release notes
label
Apr 24, 2024
github-actions
bot
added
lang/c++
and removed
release notes: no
Indicates if PR should not be in release notes
labels
Apr 24, 2024
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
Apr 24, 2024
yousukseung
force-pushed
the
generic-stub-service-refactor
branch
from
April 24, 2024 22:29
cbe5040
to
05e0e1f
Compare
yousukseung
changed the title
Generic service and generic stub refactor.
Generic service and generic stub refactor
Apr 24, 2024
yousukseung
changed the title
Generic service and generic stub refactor
[generic API] move callback to a separate target in generic stub/service
Apr 24, 2024
yousukseung
changed the title
[generic API] move callback to a separate target in generic stub/service
[generic API] separate callback from cq in generic stub/service
Apr 24, 2024
yousukseung
force-pushed
the
generic-stub-service-refactor
branch
from
April 24, 2024 22:48
05e0e1f
to
9561690
Compare
yousukseung
added
the
release notes: no
Indicates if PR should not be in release notes
label
Apr 24, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
Apr 24, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
Apr 24, 2024
yousukseung
force-pushed
the
generic-stub-service-refactor
branch
2 times, most recently
from
April 25, 2024 16:17
661dda4
to
669ca8d
Compare
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
Apr 25, 2024
yousukseung
force-pushed
the
generic-stub-service-refactor
branch
from
April 25, 2024 20:06
669ca8d
to
267205a
Compare
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
Apr 25, 2024
Awaiting grpc/proposal#426 until 5/1. |
yousukseung
force-pushed
the
generic-stub-service-refactor
branch
from
April 25, 2024 22:39
267205a
to
28df070
Compare
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
Apr 25, 2024
gRFC is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
lang/c++
per-call-memory/decrease
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See grpc/proposal#426