[metrics] Templatized Metrics API #36449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds compile-time checking that the type of the value and the size of the labels and optional labels when recording a metric must match with the type and the size specified when the metric is registered.
yijiem
added
the
release notes: no
yijiem
changed the title
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
markdroth
reviewed
Apr 25, 2024
src/core/lib/channel/metrics.h
Outdated
| @@ -87,37 +91,238 @@ class GlobalInstrumentsRegistry { | |||
| using GlobalCallbackHandle = absl::variant<GlobalCallbackInt64GaugeHandle, | |||
| GlobalCallbackDoubleGaugeHandle>; | |||
|
|
|||
| template <typename ValueType, typename InstrumentType, std::size_t M, | |||
There was a problem hiding this comment.
With all the new template stuff here, it's much harder for a reader to understand the API simply by reading the code. Can you please add a long comment immediately above the GlobalInstrumentsRegistry class that explains how it is expected to be used, both by code defining metrics and by stats plugins?
grpc-checks
bot
added
per-call-memory/increase
per-call-memory/neutral
and removed
per-call-memory/neutral
per-call-memory/increase
labels
markdroth
reviewed
Apr 27, 2024
markdroth
reviewed
Apr 27, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
markdroth
reviewed
Apr 30, 2024
markdroth
approved these changes
Apr 30, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compile-time checking that the type of the value and the size of the labels and optional labels passed when recording a metric must match with the type and the size specified when the metric is registered.
The RegistrationBuilder API idea is credited to @ctiller.