Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python tests] Allow passing kwargs to grpc.server in test_server #36455

Closed
wants to merge 4 commits into from
Closed

[Python tests] Allow passing kwargs to grpc.server in test_server #36455

wants to merge 4 commits into from

Conversation

XuanWang-Amos
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos commented Apr 25, 2024 •
edited

Allow passing kwargs to grpc.server in test server.

@XuanWang-Amos XuanWang-Amos added the release notes: no Indicates if PR should not be in release notes label Apr 25, 2024
@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review April 25, 2024 23:25
@XuanWang-Amos XuanWang-Amos changed the title [Python tests] Add an env var to disable adding addtional relefction service in tests [Python tests] Allow passing kwargs to grpc.server in test_server Apr 27, 2024
gnossen
gnossen approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnossen gnossen gnossen approved these changes

Assignees
No one assigned
Labels
lang/Python release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XuanWang-Amos @gnossen