[transport] Centralize ref-counting between transports #36460
Closed
+29
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated fix for refs/heads/transport-refs
ctiller
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
markdroth
approved these changes
Apr 30, 2024
| @@ -142,8 +142,6 @@ static bool g_default_server_keepalive_permit_without_calls = false; | |||
|
|
|||
| #define MAX_CLIENT_STREAM_ID 0x7fffffffu | |||
| grpc_core::TraceFlag grpc_keepalive_trace(false, "http_keepalive"); | |||
| grpc_core::DebugOnlyTraceFlag grpc_trace_chttp2_refcount(false, | |||
| "chttp2_refcount"); | |||
There was a problem hiding this comment.
Please remove this from the list in doc/environment_variables.md.
yashykt
added a commit
that referenced
this pull request
May 9, 2024
…" (#36566) This reverts commit 03e2bf2. I don't know why but this causes issues when building gcc7 - https://github.com/googleapis/google-cloud-cpp/pull/14153/checks?check_run_id=24734699214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.