[export] Maintain a strong reference to rpc_tasks. #36519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
exported
release notes: no
|
|
copybara-service
bot
force-pushed
the
test_629749650
branch
3 times, most recently
from
7b23f18
to
6b456c8
Compare
copybara-service
bot
force-pushed
the
test_629749650
branch
4 times, most recently
from
6cc6547
to
54dd533
Compare
copybara-service
bot
force-pushed
the
test_629749650
branch
from
54dd533
to
05ae7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[export] Maintain a strong reference to rpc_tasks.
Only a weakref is kept in the loop. See python docs on creating tasks.
https://docs.python.org/3/library/asyncio-task.html#creating-tasks
This fixes an issue with request hangs when tasks were being garbage collected.
DO NOT SUBMIT. This PR is for testing purposes only. cl/629749650