Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc_error] remove unnecessary status attributes #36523

Closed
wants to merge 27 commits into from

Conversation

markdroth
Copy link
Member

The following attributes were completely unused:

  • kOffset
  • kIndex
  • kSize
  • kFilename
  • kKey
  • kValue

The following attributes were added but never programmatically accessed, and I've moved them into the status messages themselves, which is another step toward #22883:

  • kErrorNo
  • kTsiCode
  • kWsaError
  • kHttpStatus
  • kOsError
  • kSyscall
  • kTargetAddress
  • kRawBytes
  • kTsiError

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label May 3, 2024
@markdroth markdroth requested a review from ctiller as a code owner May 3, 2024 23:48
@markdroth markdroth deleted the grpc_error_attribute_cleanup branch May 31, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants