Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log #36608

Closed
wants to merge 26 commits into from

Conversation

tanvi-jagtap
Copy link
Contributor

@tanvi-jagtap tanvi-jagtap commented May 14, 2024

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping

  1. gpr_log(GPR_INFO,...) -> LOG(INFO)
  2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
  3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :

  1. If the above mapping is correct.
  2. The content of the log is as before.

gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

@tanvi-jagtap tanvi-jagtap added the release notes: no Indicates if PR should not be in release notes label May 14, 2024
@tanvi-jagtap tanvi-jagtap marked this pull request as ready for review May 14, 2024 08:37
@tanvi-jagtap tanvi-jagtap added release notes: no Indicates if PR should not be in release notes and removed release notes: no Indicates if PR should not be in release notes labels May 14, 2024
@tanvi-jagtap tanvi-jagtap requested a review from JuneYan May 14, 2024 08:42
@tanvi-jagtap tanvi-jagtap deleted the regex_test_core_misc branch May 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants