New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L117: C-core: replace gpr logging with absl logging #425
base: master
Are you sure you want to change the base?
Conversation
Questions:
|
Yes. Removing them is the plan.
Not that I know of. However @ctiller may be able to validate that.
No changes are expected to GRPC_TRACE and related functions.
I will get back on this too. |
Re: suppressing the Ack that there'll be some grumbling. Re: GRPC_VERBOSITY: I'd propose we introduce some code that if it's set overrides the absl defaults -- but if it's not set we exert no opinion on what absl does. |
This may cause a lot of frustration with our users, i.e. people may perceive it as some real issue and end up spending time trying to figure out how to fix it, then having to add a dependency to ABSL log (and that may be challenging for people with weird build systems). I feel like we need to be user friendly. |
…acing-gpr-logging-with-abseil-logging.md
…replacing-gpr-logging-with-abseil-logging.md
…cpp-replacing-gpr-logging-with-abseil-logging.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this up! Comments are mostly costmetic.
Please let me know if you have any questions. Thanks!
…core-replace-gpr-logging-with-abseil-logging.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.