Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L117: C-core: replace gpr logging with absl logging #425

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

tanvi-jagtap
Copy link

No description provided.

@eugeneo
Copy link
Contributor

eugeneo commented Apr 17, 2024

Questions:

  1. Will gpr_log and friends get removed or will they remain and wrap ABSL APIs?
  2. Are there any ABSL logging features we should not use in gRPC?
  3. Will GRPC_VERBOSITY and GRPC_TRACE env variables keep working?
  4. Is there a way to suppress the absl::InitializeLog warning for our users? It will force them to add dependency to ABSL to their main function and I anticipate a lot of grumbling.

@tanvi-jagtap
Copy link
Author

Questions:

  1. Will gpr_log and friends get removed or will they remain and wrap ABSL APIs?

Yes. Removing them is the plan.

  1. Are there any ABSL logging features we should not use in gRPC?

Not that I know of. However @ctiller may be able to validate that.

  1. Will GRPC_VERBOSITY and GRPC_TRACE env variables keep working?

No changes are expected to GRPC_TRACE and related functions.
I will get back to you on GRPC_VERBOSITY . There are some things I need to look into.

  1. Is there a way to suppress the absl::InitializeLog warning for our users? It will force them to add dependency to ABSL to their main function and I anticipate a lot of grumbling.

I will get back on this too.

@ctiller
Copy link
Member

ctiller commented Apr 17, 2024

Re: suppressing the absl::InitializeLog warning: I highly recommend not doing so. That behavior is controlled by absl, and if we introduce mechanisms over top by default then we're fighting their defaults which is going to lead to more confusion - especially since it's unallowed to call InitializeLog twice.

Ack that there'll be some grumbling.

Re: GRPC_VERBOSITY: I'd propose we introduce some code that if it's set overrides the absl defaults -- but if it's not set we exert no opinion on what absl does.

@eugeneo
Copy link
Contributor

eugeneo commented Apr 17, 2024

Ack that there'll be some grumbling.

This may cause a lot of frustration with our users, i.e. people may perceive it as some real issue and end up spending time trying to figure out how to fix it, then having to add a dependency to ABSL log (and that may be challenging for people with weird build systems).

I feel like we need to be user friendly.

@ctiller ctiller changed the title gRFC for gpr logging to absl logging L116: gRFC for gpr logging to absl logging Apr 23, 2024
@tanvi-jagtap tanvi-jagtap changed the title L116: gRFC for gpr logging to absl logging L117: gRFC for gpr logging to absl logging Apr 29, 2024
@markdroth markdroth changed the title L117: gRFC for gpr logging to absl logging L117: C-core: replace gpr logging with absl logging May 1, 2024
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! Comments are mostly costmetic.

Please let me know if you have any questions. Thanks!

L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
L117-cpp-replacing-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

L117-core-replace-gpr-logging-with-abseil-logging.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants