Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L115: Refactor generic service and generic stub #426

Merged
merged 4 commits into from May 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 42 additions & 0 deletions L115-core-refactor-generic-service-stub.md
@@ -0,0 +1,42 @@
L115: C-Core Refactor generic service and generic stub
----
* Author(s): ysseung
* Approver: ctiller
* Status: Draft
* Implemented in: C Core
* Last updated: 2024/04/15
* Discussion at: https://groups.google.com/g/grpc-io/c/301w3zXYf8o

## Abstract

We will refactor `async_generic_service.h` and `generic_stub.h` to move
callback based interfaces into separate targets. Existing files will include
the callback based interfaces.

## Background

This enables services to only depend on the callback based interfaces of the
generic stub and generic service.

### Related Proposals

None.

## Proposal

We will move `CallbackGenericService` in `async_generic_service.h` to a new file
`callback_generic_service.h` and make it a new public target
`:callback_generic_service`. `async_generic_service.h` will include
`callback_generic_service.h` and existing dependencies will continue to
include both.

We will also move move callback based interfaces of `TemplatedGenericStub` in
`generic_stub.h` to a new class `TemplatedGenericStubCallback` in
`generic_stub_callback.h` and make it a new public target
`:generic_stub_callback`. `CallbackGenericService` will inherit
`CallbackGenericService` and existing dependencies will continue to
include both.

## Implementation

https://github.com/grpc/grpc/pull/36447