Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ie11 support #62

Closed
wants to merge 3 commits into from
Closed

Ie11 support #62

wants to merge 3 commits into from

Conversation

kieran-allen
Copy link
Collaborator

Helps resolve some bugs: #47

  • Downgrade the version of fetch-mock to v6.5.2. This is due to an issue with newer versions of the library which use Proxy.
  • Update tests
  • Update the gotchas section of the readme to inform the reason for downgrading the version of the fetch-mock library.

@kieran-allen kieran-allen requested a review from grug May 22, 2020 14:12
@grug
Copy link
Owner

grug commented May 22, 2020

First of all - thank you so much for contributing this!

I'm just not sure I'm alright with rolling back the version of fetch-mock that far. I'm aware of some of the changes that @wheresrhys is doing with it and it will make for better testing if we can keep the version up to date.

What's the issue here? Is it that Proxy needs polyfilling? If so, maybe the gotcha here for ie11 users is that they need it polyfilled.

What are people's thoughts?

@kieran-allen
Copy link
Collaborator Author

That's a fair point!

Yeah, it looks like Proxy would need polyfilling for this to work nicely with ie11.

https://github.com/GoogleChrome/proxy-polyfill is something that does exist ( although I haven't looked into it yet ).

Might be worth looking into it.

@wheresrhys
Copy link

The PR in whatwg-fetch to fix all this has been merged, and hopefully there will be a patch release soon. Following that fetch-mock should be compatible with the proxy polyfill

@grug
Copy link
Owner

grug commented May 29, 2020

Perfect - thanks for that info @wheresrhys :)

@github-actions
Copy link

Hi there :) This PR hasn't received any attention in a while. Can it be closed or does it require more work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants