Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket Support #77

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Websocket Support #77

wants to merge 15 commits into from

Conversation

aidenscott2016
Copy link

@aidenscott2016 aidenscott2016 commented Sep 14, 2021 •
edited

We have had a need to mock a WS server at OVO using this library. This work implements that.

See tests for usage

aidenscott2016
aidenscott2016 commented Sep 14, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@grug
Copy link
Owner

grug commented Sep 14, 2021

This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!

@grug
Copy link
Owner

grug commented Sep 15, 2021

Aiden I need to see a dank meme before I can approve this work.

aidenscott2016
aidenscott2016 commented Sep 15, 2021
View reviewed changes
tsconfig.json Outdated
"noUnusedLocals": true /* Report errors on unused locals. */,
"noUnusedParameters": true /* Report errors on unused parameters. */,
"noUnusedLocals": false /* Report errors on unused locals. */,
"noUnusedParameters": false /* Report errors on unused parameters. */,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change comes from within, brother 😌

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inshallah

aidenscott2016
aidenscott2016 commented Sep 15, 2021
View reviewed changes
README.md Outdated
@@ -1,5 +1,8 @@
# data-mocks

# modified by aiden for websocket support.
# will hopefully be deleted soon when merged in to upstream

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also write usage

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this up?

aidenscott2016
aidenscott2016 commented Sep 15, 2021
View reviewed changes
src/mocks.test.ts Outdated Show resolved Hide resolved
aidenscott2016
aidenscott2016 commented Sep 15, 2021
View reviewed changes
src/mocks.ts Outdated Show resolved Hide resolved
@aidenscott2016
Copy link
Author

aidenscott2016 commented Sep 15, 2021 •
edited

@grug

This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!

You're welcome. We needed to mock websockets any way and it didn't make sense two sets of mocking infra

Aiden I need to see a dank meme before I can approve this work.

It will take a long time to find a suitably dank meme for a PR of this calibre. Now I can see there is an appetite to upstream this I will more than likely clean this up on my next 10pc day next friday

@aidenscott2016
Copy link
Author

@HamishDixon morley has aske me to remind you that you are a flim-flam

@grug
Copy link
Owner

grug commented Sep 15, 2021

@aidenscott2016 please remind Morley that I am his dad.

@aidenscott2016 aidenscott2016 marked this pull request as ready for review September 24, 2021 12:36
@aidenscott2016
Copy link
Author

@grug this is ready for merge

@aidenscott2016 aidenscott2016 changed the title Draft PR to support websockets Websocket Support Sep 24, 2021
grug
grug reviewed Sep 24, 2021
View reviewed changes
README.md Outdated
@@ -1,5 +1,8 @@
# data-mocks

# modified by aiden for websocket support.
# will hopefully be deleted soon when merged in to upstream

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this up?

README.md Outdated Show resolved Hide resolved
@grug
Copy link
Owner

grug commented Sep 24, 2021

I'm going to have to run this stuff locally and see how it all works as I feel like people can get pretty fancy with their websocket setups so I want to see how this stands up against some weird configurations.

Repository owner deleted a comment from aidenscott2016 Sep 24, 2021
Repository owner deleted a comment from aidenscott2016 Sep 24, 2021
aidenscott2016 and others added 2 commits September 24, 2021 14:14
@aidenscott2016 @grug
Update README.md
0340b2d 
Co-authored-by: Dave Cooper <dave@davecooper.dev>
readme
c7f7f4b
@aidenscott2016
Copy link
Author

thumbs up emoji

@grug
Copy link
Owner

grug commented Oct 29, 2021

@aidenscott2016 are you still okay with all of this? I'm thinking of merging and releasing today :)

@aidenscott2016
Copy link
Author

@grug ye man merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevrowe kevrowe kevrowe left review comments

@grug grug grug left review comments

@stephen-thompson-77 stephen-thompson-77 stephen-thompson-77 left review comments

@HarrisonBaxter HarrisonBaxter HarrisonBaxter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aidenscott2016 @grug @kevrowe @stephen-thompson-77 @HarrisonBaxter