Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option log #154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add new option log #154

wants to merge 4 commits into from

Conversation

paladox
Copy link

@paladox paladox commented Mar 25, 2016

The default is set as true.

This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information.

Follows up #145

And fixes #153

The default is set as true.

This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information.

Follows up https://github.com/gruntjs/grunt-contrib-concat/pull/145/files

And fixes gruntjs#153
@paladox
Copy link
Author

paladox commented Mar 25, 2016

@shama or @vladikoff could you review and merge please.

@shama
Copy link
Member

shama commented Mar 25, 2016

I don't think adding more options to plugins is a good way to solve this. We should think through and submit a rfc that gives end users more control over how grunt logs.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

Yes currently we carn't see what is created unless we add verbose which not only affects this but affects other scripts showing too much information that we doint want to see.

@Arkni
Copy link
Member

Arkni commented Mar 25, 2016

Quoting @vladikoff's comment in #145:

We should also add a total message like other plugins do, i.e "X files created" in the end

This should be the right way to go, without adding any other option.

@shama
Copy link
Member

shama commented Mar 25, 2016

I understand. The previous PR changing it to verbose wasn't a good solution either. I think we should come up with a good solution to fix the actual problem, giving users more control over grunt log.

I recommend using a previous version of this plugin in the meantime.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

@shama could we revert that change then, and instead follow what you said and improve it in grunt instead please.

@vladikoff
Copy link
Member

I understand. The previous PR changing it to verbose wasn't a good solution either. I think we should come up with a good solution to fix the actual problem, giving users more control over grunt log.

Multiple other plugins switched to verbose only, users are concating over 100 files and logging everything by default is not a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grunt-contrib-concat 1.0.0 problems
4 participants