Update to Puppeteer 5 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some internal breaking changes, but nothing that affects this project afaik. https://github.com/puppeteer/puppeteer/releases/tag/v5.0.0 Main reason for updating is so that 5.3.0 becomes in-range, which introduced support for PUPPETEER_DOWNLOAD_PATH, which can be set to a cached directory (e.g. for CI to save/restore, or to persist locally in a way compatible with npm-ci) Ref puppeteer/puppeteer#6014
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jul 4, 2021
* Puppeteer stores the Chromium binary only in node_modules/ (not in $XDG_CACHE_HOME or some other directory that is generally persisted in dev and CI environments, nor in any other directory that one can opt-in to caching/persistence). This was fixed in Puppeteer 5+ (ref puppeteer/puppeteer#6014), through an opt-in PUPPETEER_DOWNLOAD_PATH env var. * I enalbed this in commit 7cd99a2, but it didn't do anything yet as grunt-contrib-qunit wasn't using the newer Puppeteer yet. This was fixed in gruntjs/grunt-contrib-qunit#173.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jul 4, 2021
* Puppeteer stores the Chromium binary only in node_modules/ (not in $XDG_CACHE_HOME or some other directory that is generally persisted in dev and CI environments, nor in any other directory that one can opt-in to caching/persistence). This was fixed in Puppeteer 5+ (ref puppeteer/puppeteer#6014), through an opt-in PUPPETEER_DOWNLOAD_PATH env var. * I enalbed this in commit 7cd99a2, but it didn't do anything yet as grunt-contrib-qunit wasn't using the newer Puppeteer yet. This was fixed in gruntjs/grunt-contrib-qunit#173. * Fix ENV syntax since tildes aren't expanded in this context.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jul 4, 2021
* Puppeteer stores the Chromium binary only in node_modules/ (not in $XDG_CACHE_HOME or some other directory that is generally persisted in dev and CI environments, nor in any other directory that one can opt-in to caching/persistence). This was fixed in Puppeteer 5+ (ref puppeteer/puppeteer#6014), through an opt-in PUPPETEER_DOWNLOAD_PATH env var. * I enalbed this in commit 7cd99a2, but it didn't do anything yet as grunt-contrib-qunit wasn't using the newer Puppeteer yet. This was fixed in gruntjs/grunt-contrib-qunit#173. * Fix ENV syntax (tildes aren't expanded in this context, other variables like $HOME aren't expanded either, and absolute paths like /tmp also can't because Windows runners interpret /tmp as D:\tmp which doesn't exist by default, and Puppeteer requires the parent dir to exist instead of lazy-creating it). Use a local subdirectory instead.
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Jul 4, 2021
* Puppeteer stores the Chromium binary only in node_modules/ (not in $XDG_CACHE_HOME or some other directory that is generally persisted in dev and CI environments, nor in any other directory that one can opt-in to caching/persistence). This was fixed in Puppeteer 5+ (ref puppeteer/puppeteer#6014), through an opt-in PUPPETEER_DOWNLOAD_PATH env var. * I enalbed this in commit 7cd99a2, but it didn't do anything yet as grunt-contrib-qunit wasn't using the newer Puppeteer yet. This was fixed in gruntjs/grunt-contrib-qunit#173. * Fix ENV syntax. - Tildes aren't expanded in this context. - Other variables like $HOME aren't expanded either. - Absolute paths like /tmp can't be used because Windows runners interpret `/tmp` as `D:\tmp`, which doesn't exist by default, and Puppeteer requires the parent dir to exist instead of simply lazy-creating it. - Can't use a relative directory in the workspace like ".puppeteer" because Puppeteer insists on the variable being an absolute path. - We can use the `github.workspace` builtin variable, which we can subsitute per <https://git.io/JUJEE>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal breaking changes, but nothing that affects this project
afaik. https://github.com/puppeteer/puppeteer/releases/tag/v5.0.0
Main reason for updating is so that 5.3.0 becomes in-range,
which introduced support for PUPPETEER_DOWNLOAD_PATH, which can
be set to a cached directory (e.g. for CI to save/restore, or to
persist locally in a way compatible with npm-ci)
Ref puppeteer/puppeteer#6014