Release 8.0.0: upgrade to Puppeteer 21, require Node 16+ #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Krinkle, hey, how are you? Are the tests failing since now we are requesting a node version ≥16? Maybe we should update these tests. I opened an issue cause I'm facing a problem when installing Puppeteer and I think that you have the solution here! :D |
package.json
Outdated
| @@ -18,12 +18,12 @@ | |||
| "dependencies": { | |||
| "eventemitter2": "^6.4.9", | |||
| "p-each-series": "^2.2.0", | |||
| "puppeteer": "^19.7.0" | |||
| "puppeteer": "^20.9.0" | |||
There was a problem hiding this comment.
We already have the version 21.1.1 for Puppeteer
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "difflet": "^1.0.1", | ||
| "grunt": "^1.6.1", | ||
| "grunt-contrib-connect": "^3.0.0", | ||
| "grunt-contrib-connect": "^4.0.0", | ||
| "grunt-contrib-internal": "^8.0.2", |
There was a problem hiding this comment.
There is the version 9.0.0 to grunt-contrib-internal as well
There was a problem hiding this comment.
Ack, I created this release at gruntjs/grunt-contrib-internal#57 after drafting this PR. The PR was blocked on 9.0.0 being released first, because grunt-contrib-internal is what manages our CI configuration. This PR raises the Node requirement to Node 16, which thus needs a change to the CI config to drop the Node 14 jobs.
From grunt-contrib-connect 4.0.0: > gruntjs/grunt-contrib-connect#282 > * Fix deprecation warning about `opn@6`. From puppeteer 20: > https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.0.0 > * switch from Chromium to "Chrome for Testing". From puppeteer 20.9.0: > https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v20.9.0 > * roll to Chrome 115 From puppeteer 21.1.0: > https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v21.1.0 > * roll to Chrome 116 General "Chrome for Testing" announcement at [1]. Based on reading the linked design document [2] [3], I believe "Chrome for Testing" continues to be a build of open-source Chromium. It is not compiled from or with proprietary Google Chrome components. Rather, it is a Chromium build that is 1) compiled feature flags and defaults settings as similar to Google Chrome as possible, and 2) built and published from the same Chromium revisions and at the same cadence as Chrome releases. This means, that anytime a Google Chrome release happens for Stable or Beta channel, there is also a Chrome for Testing release. Having said that, the design document does acknowledge that a previous proposal (nicknamed "Chrome-", meaning start with Chrome and subtract unwanted features) did exist. This was rejected in favour of "Chromium+" which works as above with the Chrome-like app icon injected from their build system from outside the Chromium source tree. [1] https://developer.chrome.com/blog/chrome-for-testing/ [2] https://docs.google.com/document/d/1XJvxyqAQjhPfJ0rX84PjfXXb5sBx3m8DXzMxR0ipQNs/edit [3] http://web.archive.org/web/20230503104427/https://docs.google.com/document/d/1XJvxyqAQjhPfJ0rX84PjfXXb5sBx3m8DXzMxR0ipQNs/edit From puppeteer 19.11: > https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v19.11.0 > * add warning for `headless: true` There is no more pretending that Chrome Headless wasn't actually "Chrome but headless" (like Firefox Headless), but a separate browser implementation [4]. "Fake it until you make it". Starting in Chrome 112, there is a "new" headless mode, which is now claimed to actually be "Chrome, but headless". I propose that in grunt-contrib-qunit 8.0, with the switch to "Chromium for Testing", we also switch to this mode at the same time. If we don't, Puppeteer prints the following warning on every CI build: > Puppeteer old Headless deprecation warning: > In the near feature `headless: true` will default to the new Headless mode > Consider opting in early by passing `headless: "new"` to `puppeteer.launch()` [4] https://developer.chrome.com/articles/new-headless/
Krinkle
changed the title
Gabriel-Dias-Oliveira
approved these changes
Sep 6, 2023
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 16, 2023
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 16, 2023
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 16, 2023
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 16, 2023
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 16, 2023
It's up on npm now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From grunt-contrib-connect 4.0.0:
From puppeteer 20:
From puppeteer 20.9.0:
From puppeteer 21.1.0:
General "Chrome for Testing" announcement at [1].
Based on reading the linked design document [2] [3], I believe
"Chrome for Testing" continues to be a build of open-source Chromium.
It is not compiled from or with proprietary Google Chrome components.
Rather, it is a Chromium build that is 1) compiled feature flags and
defaults settings as similar to Google Chrome as possible, and 2)
built and published from the same Chromium revisions and at the same
cadence as Chrome releases. This means, that anytime a Google Chrome
release happens for Stable or Beta channel, there is also a
Chrome for Testing release.
Having said that, the design document does acknowledge that a previous
proposal (nicknamed "Chrome-", meaning start with Chrome and subtract
unwanted features) did exist. This was rejected in favour of "Chromium+"
which works as above with the Chrome-like app icon injected from their
build system from outside the Chromium source tree.
[1] https://developer.chrome.com/blog/chrome-for-testing/
[2] https://docs.google.com/document/d/1XJvxyqAQjhPfJ0rX84PjfXXb5sBx3m8DXzMxR0ipQNs/edit
[3] http://web.archive.org/web/20230503104427/https://docs.google.com/document/d/1XJvxyqAQjhPfJ0rX84PjfXXb5sBx3m8DXzMxR0ipQNs/edit
From puppeteer 19.11:
There is no more pretending that Chrome Headless wasn't actually
"Chrome but headless" (like Firefox Headless), but a separate browser
implementation [4]. "Fake it until you make it". Starting in Chrome 112,
there is a "new" headless mode, which is now claimed to actually be
"Chrome, but headless". I propose that in grunt-contrib-qunit 8.0,
with the switch to "Chromium for Testing", we also switch to this
mode at the same time.
If we don't, Puppeteer prints the following warning on every CI build:
[4] https://developer.chrome.com/articles/new-headless/