Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded go-git to v5.6.1 #120

Closed
wants to merge 2 commits into from
Closed

Upgraded go-git to v5.6.1 #120

wants to merge 2 commits into from

Conversation

bloudraak
Copy link

Description

Fixes #118.

Upgrades go-git to v5.6.1. This update fixes an issue where some repositories fail to clone with error message "reference delta not found."

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated go-git to v5.6.1.

Migration Guide

No migration needed.

This change updates go-git to v5.6.1 and dependent packages.  This update fixes an issue where some repositories fail to clone.
@zackproser
Copy link
Contributor

@bloudraak Thanks kindly for the PR! I've kicked off tests.

@zackproser
Copy link
Contributor

The fix for this is in PR #122 - once that is merged, we can rebase this PR against master and that will fix the current build issue occurring in CircleCI.

@zackproser
Copy link
Contributor

Okay @bloudraak could you kindly rebase your PR on master when you get a chance? That will pull in the Go 1.18 version upgrade required to fix the current build issue.

Thanks again!

@zackproser
Copy link
Contributor

Because your PR required me to resolve some conflicts in your fork which I didn't have access to, I opted to make the same change myself in the interest of getting this fix out more quickly.

Thanks so much for opening this and offering a fix. I really appreciate it!

@zackproser zackproser closed this May 10, 2023
@bloudraak bloudraak deleted the package-upgrade branch May 10, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "reference delta not found" when cloning repositories
2 participants