Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vault support for sops encryption mechanism #1564

Merged
merged 12 commits into from
Apr 15, 2021

Conversation

teamfighter
Copy link
Contributor

@teamfighter teamfighter commented Feb 26, 2021

This pull request related to #1562

As used go.mozilla.org/sops/v3 v3.5.0 does not support hashicorp vault, I bumped this go module to v3.6.1
Also added github.com/hashicorp/vault v1.6.2 to avoid ambiguous import error while building binary.
I ran go test -v ./..., here is the output in gist.

I hope provided information is enough to merge this PR.

@teamfighter
Copy link
Contributor Author

@yorinasub17 @brikis98 any updates on this please?

@brikis98
Copy link
Member

Thanks for the PR! Apologies for the delay. We are super buried right now. We'll get to this as soon as we can.

@TiagoJMartins
Copy link

This would be super useful.

@teamfighter
Copy link
Contributor Author

@brikis98 Hello. Any updates?

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and your patience as we got around to reviewing this!

I see the updates to go.mod... But there should be a corresponding auto-generated update to go.sum as well. Could you include that in the PR?

go.mod Outdated Show resolved Hide resolved
@teamfighter
Copy link
Contributor Author

Thanks for your PR and your patience as we got around to reviewing this!

I see the updates to go.mod... But there should be a corresponding auto-generated update to go.sum as well. Could you include that in the PR?

@brikis98 I have updated go.sum, could you please check it.

@teamfighter teamfighter force-pushed the add-vault-support-for-sops branch 2 times, most recently from 7e57e70 to 2ac00c0 Compare March 31, 2021 18:31
@michelzanini
Copy link

Hi @teamfighter,

I have this issue here #1629.
To fix it I need SOPS 1.7.0 and I see here you are already upgrading SOPS to 1.6.1.

Could you bump it 1.7.0 on this PR? That way you would be fixing my problem too.

Thanks.

@teamfighter
Copy link
Contributor Author

teamfighter commented Apr 4, 2021

Hi @teamfighter,

I have this issue here #1629.
To fix it I need SOPS 1.7.0 and I see here you are already upgrading SOPS to 1.6.1.

Could you bump it 1.7.0 on this PR? That way you would be fixing my problem too.

Thanks.

This will require additional testing. I'll try to do this today.

@teamfighter
Copy link
Contributor Author

@brikis98 I resolved merge conflicts and bumped sops to 3.7.0, vault to 1.7.0
Here is related tests results
https://gist.github.com/teamfighter/71dfa6c8533f6c71a56e5421c914f580

Please take a look.

brikis98
brikis98 previously approved these changes Apr 7, 2021
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll kick off tests now.

@teamfighter
Copy link
Contributor Author

As I can see, unit tests are failed. Should I fix something? If so, what exactly?

@brikis98
Copy link
Member

brikis98 commented Apr 7, 2021

I think this is the error:

# github.com/gruntwork-io/terragrunt/cli
cli/hclfmt_test.go:9:2: missing go.sum entry for module providing package github.com/gruntwork-io/terratest/modules/files (imported by github.com/gruntwork-io/terragrunt/cli); to add:
	go get -t github.com/gruntwork-io/terragrunt/cli
FAIL	github.com/gruntwork-io/terragrunt/cli [setup failed]

@teamfighter
Copy link
Contributor Author

I think this is the error:

# github.com/gruntwork-io/terragrunt/cli
cli/hclfmt_test.go:9:2: missing go.sum entry for module providing package github.com/gruntwork-io/terratest/modules/files (imported by github.com/gruntwork-io/terragrunt/cli); to add:
	go get -t github.com/gruntwork-io/terragrunt/cli
FAIL	github.com/gruntwork-io/terragrunt/cli [setup failed]

I executed go get -t github.com/gruntwork-io/terragrunt/cli, and pushed changed go.sum file.
Could you please kick-off tests again?

@brikis98
Copy link
Member

brikis98 commented Apr 9, 2021

Re-running...

This was referenced Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants