Mock disabled dependency outputs. #2816
Open
+6
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using disabled dependency outputs wasn't really working because it would require that the `terragrunt.hcl` file as present, which was a bug. Additionally, disabled dependencies didn't have mocked outputs loaded, which doesn't really make sense otherwise. See [1] for more details. This commit as a whole addresses [2]. [1] gruntwork-io#2734 (comment) [2] gruntwork-io#2734 (comment)
|
I've tested this by ensuring it solves problems I've been seeing, describe in more detail in #2734 (comment), following the docs to run |
2 tasks
|
Failing test |
|
Also will be helpful to have integration tests that will track that disabled modules work as expected |
Agh, I'm struggling a bit to fix/update this. Can you help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2734.
Previously, using disabled dependency outputs wasn't really working because it would require that the
terragrunt.hclfile as present, which was a bug. Additionally, disabled dependencies didn't have mocked outputs loaded, which doesn't really make sense otherwise.Release Notes (draft)
Updated disabled dependencies to properly use mocked outputs.
Migration Guide
n/a