Add configuration options for AWS S3 server access logging #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findmyname666
changed the title
4 tasks
denis256
reviewed
Mar 19, 2024
| SkipAccessLoggingBucketAcl bool `mapstructure:"skip_accesslogging_bucket_acl"` | ||
| SkipAccessLoggingBucketEnforcedTLS bool `mapstructure:"skip_accesslogging_bucket_enforced_tls"` | ||
| SkipAccessLoggingBucketPublicAccessBlocking bool `mapstructure:"skip_accesslogging_bucket_public_access_blocking"` | ||
| SkipAccessLoggingBucketSSEncryption bool `mapstructure:"skip_accesslogging_bucket_ssencryption"` |
There was a problem hiding this comment.
Could you please consider adding tests to ensure that the newly added fields are functioning as expected?
There was a problem hiding this comment.
Hi @denis256, Thx for your feedback. I tried to updated existing existing tests and added one new for method createS3LoggingInput. Please let me know if I missed anything else.
There was a problem hiding this comment.
Hi @denis256 , Can I politely ask you for re-review once you have some free time please? Thx.
There was a problem hiding this comment.
Hi @denis256, do you think you'll have time to take a look on this PR in the upcoming days?
findmyname666
force-pushed
the
feature/s3-new-options-access-logging-3003
branch
from
675daef
to
e4b533b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3003.
In our environment the S3 bucket where should be stored S3 access logs is pre-created by "central" team and we don't have permissions to do any changes. In such case we don't have to:
PartitionDateSource.Additionally 1) adding error logging into the function
configureAccessLogBucket. Without it I wasn't able to detect why the logging isn't configured on the source bucket. The error is returned but ignored. 2) Adding code to detect if the logging policy / configuration was change. The previous code just check if some policy is enabled.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide
N/A.