Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support discovery of symlinked modules #3101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support discovery of symlinked modules #3101

wants to merge 1 commit into from

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Apr 26, 2024 •
edited

Description

Support discovery of symlinked modules with the help of https://github.com/edwardrf/symwalk.

Fixes #1611

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

Added support for discovery of symlinked modules

@aslafy-z aslafy-z force-pushed the patch-1 branch 5 times, most recently from 092f02f to 918d571 Compare April 26, 2024 11:39
@aslafy-z
fix: symlink support
8bac38d 
Signed-off-by: GitHub <noreply@github.com>
@aslafy-z aslafy-z changed the title fix: symlink support feat: support discovery of symlinked modules Apr 26, 2024
@aslafy-z aslafy-z marked this pull request as ready for review April 26, 2024 11:54
@aslafy-z aslafy-z requested a review from denis256 as a code owner April 26, 2024 11:54
@aslafy-z aslafy-z mentioned this pull request Apr 26, 2024
Open
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Apr 26, 2024 •
edited

@denis256 This PR is ready for review, please let me know if it need changes.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@denis256
Copy link
Member

Conflicting files
go.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symlinks in Terragrunt
2 participants
@aslafy-z @denis256