Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --set-json flag support for the helm module #1291

Merged
merged 1 commit into from
May 22, 2023
Merged

add --set-json flag support for the helm module #1291

merged 1 commit into from
May 22, 2023

Conversation

ganievs
Copy link
Contributor

@ganievs ganievs commented May 22, 2023 •
edited

Description

Add an ability to provide JSON values

Fixes #1292

TODOs

Read the Gruntwork contribution guidelines.

  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added ability to define JSON values for the --set-json Helm template flag

@ganievs
add --set-json flag support for the helm module
a1eca26 
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
@ganievs ganievs mentioned this pull request May 22, 2023
Closed
@denis256 denis256 merged commit 5389a85 into gruntwork-io:master May 22, 2023
3 checks passed
@ganievs ganievs deleted the feature/helm-set-json branch May 22, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass json values for the Helm template
2 participants
@ganievs @denis256