Update azure workflow golangcli-lint version #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI link. Failures in the CI are expected due to restrictions on the Azure account used fro testing from deploying certain type of resources for Quote limits. |
sweanan
approved these changes
Jun 13, 2023
denis256
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRFixes faild azure CI to unblock testing of Azure contributions like #1303 by:
[X] Updates the Azure workflow to use golangci-lint v1.53.2 since after updating go version requirement to be 1.19.
[X] Replace the expired certificate used for testing Azure_key_vault_certificate resource.
[X] Update the azurerm version for the Azure Key Vault example and update the example Key Vault properties.