Add 4 new variables for NSGRuleSummary #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It will add only new variables in struct NsgRuleSummary, it will not change functionality.
I use function GetAllNSGRules and at it function FindRuleByName but currently it return empty value if your rule have list of strings for variables.
Variables returned from network.SecurityRulePropertiesFormat in method convertToNsgRuleSummary, so solve problem is easy and all to do is catch this values.
If i add in to struct NsgRuleSummary variables
And assign them to values from rules in convertToNsgRuleSummary then function FindRuleByName should return for me expected data with all []string where are need.