update go version

[danielperaltamadriz]

Description

Fixes #1337.

Update Golang version to 1.21.1

TODOs

Read the Gruntwork contribution guidelines.

• Update the docs.
• Run the relevant tests successfully, including pre-commit checks.
• Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Update Golang version to 1.21.1
Added / Removed / Updated [X].

[denis256]

Noticed failing tests:

TestIntegrationBasicExample

Failed
<property name="go.version" value="go1.21.1"></property>
		<property name="go.version" value="go1.19"></property>
integration_test.go:51: 
Error Trace:	/home/circleci/project/modules/logger/parser/integration_test.go:51
            				/home/circleci/project/modules/logger/parser/integration_test.go:61
Error:      	Should be true
Test:       	TestIntegrationFailingExample


TestIntegrationPanicExample

Failed
<property name="go.version" value="go1.21.1"></property>
		<property name="go.version" value="go1.19"></property>
integration_test.go:51: 
Error Trace:	/home/circleci/project/modules/logger/parser/integration_test.go:51
            				/home/circleci/project/modules/logger/parser/integration_test.go:56
Error:      	Should be true
Test:       	TestIntegrationBasicExample

TestIntegrationNewGoExample

Failed
<property name="go.version" value="go1.21.1"></property>
		<property name="go.version" value="go1.19"></property>
integration_test.go:51: 
Error Trace:	/home/circleci/project/modules/logger/parser/integration_test.go:51
            				/home/circleci/project/modules/logger/parser/integration_test.go:66
Error:      	Should be true
Test:       	TestIntegrationPanicExample

[antoninbas]

that is quite unusual to have a patch version requirement in the go.mod (go 1.21.1 instead of go 1.21).
it also means that all projects that import github.com/gruntwork-io/terratest will need to have the same requirement, and their go.mod file will be mutated when running go mod tidy.
is there a specific reason for the strict requirement?

[danielperaltamadriz]

Hi, as far as I understand, the strict requirement is done by golang since the 1.21 version. Even if the go.mod file only has 1.21, it implies that all the modules that depend on this need to have at least go 1.21.0 installed.
https://tip.golang.org/doc/toolchain#config

In regards to the add of the patch version, since 1.21 the go toolchain requires the patch version as part of the name, so to avoid issues is recommended to add the patch as part of the go.mod version
golang/go#62278

[antoninbas]

Thanks for the link. I was not aware of this change in go 1.21. But based on the discussion there, it feels like the go directive here should be go 1.21.0, and not go 1.21.1, which forces all modules using this one to also use go 1.21.1.

[danielperaltamadriz]

I chose 1.21.1 because it was the latest version at that moment, but sure, I'll submit a PR to downgrade the version to 1.21.0.

[danielperaltamadriz]

PR: #1349