codegen: Fix nullable array in function params #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andy Russell <arussell123@gmail.com> Fixes #1133
|
Ok seems like gir doesn't give us a way to know if the array is zero-terminated or not...that makes it more difficult |
Why? That seems like the correct thing to do, even if it's inconvenient.
It's an attribute in the XML though. |
I know, but it is not parsed nor passed around... |
Uh... what?! 🤣 We assume always that it's zero-terminated unless there is an array length? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Andy Russell arussell123@gmail.com
Fixes #1133
Take over of #1136 except it only generates Option if it is not a return type. To avoid generating
Option<Vec<T>>