RFC: Make WeakRef cheaply cloneable #1045
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heftig
changed the title
heftig
force-pushed
the
weakref-arc
branch
2 times, most recently
from
2cabe2c
to
d32746b
Compare
By using an `Arc` instead of a `Box`, we can make `WeakRef::clone` a cheap operation, compared to taking a global write lock for setting a `GWeakRef`. The extra space used for the refcounts should be a fine trade-off.
|
Using |
sdroege
reviewed
Mar 7, 2023
| @@ -3461,27 +3468,27 @@ impl<T: ObjectType> Default for WeakRef<T> { | |||
| } | |||
| } | |||
|
|
|||
| unsafe impl<T: ObjectType + Sync + Sync> Sync for WeakRef<T> {} | |||
There was a problem hiding this comment.
Oops. Can you make a separate PR for this?
Yes that seems problematic. Also did you consider improving the situation in C by moving this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using an
Arcinstead of aBox, we can makeWeakRef::clonea cheap operation, compared to taking a global write lock for setting aGWeakRef. The extra space used for the refcounts should be a fine trade-off.