RFC: glib: Add optional support for serialization and deserialization with serde #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmnscnce
force-pushed
the
serde
branch
2 times, most recently
from
3479d6a
to
6c67b19
Compare
sdroege
requested review from
pbor,
sdroege,
GuillaumeGomez,
bilelmoussaoui,
ranfdev and
jf2048
|
I like this and we have something similar in place in the GStreamer bindings already. You probably want to mention this new feature in the README.md though. Also do you see a possibility of moving all that repetitive code into a macro or two? :) |
|
Looks like a good idea. |
rmnscnce
force-pushed
the
serde
branch
4 times, most recently
from
5e2d762
to
d95e941
Compare
sdroege
reviewed
Apr 6, 2023
glib/Cargo.toml
Outdated
| @@ -59,6 +60,7 @@ log_macros = ["log"] | |||
| dox = ["ffi/dox", "gobject_ffi/dox", "log_macros"] | |||
| compiletests = [] | |||
| gio = ["gio_ffi"] | |||
| serialize = ["dep:serde"] | |||
There was a problem hiding this comment.
I wanted to use serde but seems like the tests break on it.
https://github.com/gtk-rs/gtk-rs-core/actions/runs/4616156154/jobs/8160815190#step:19:414
https://github.com/gtk-rs/gtk-rs-core/tree/5e2d7622885fd64cfbf7a727273d78368cdc139e
There was a problem hiding this comment.
Hrm that looks like a bug in trybuild2. @GuillaumeGomez you're maintaining that, can you take a look? :)
There was a problem hiding this comment.
I published a new version of trybuild2 with the commits of the upstream trybuild.
sdroege
reviewed
Apr 6, 2023
sdroege
reviewed
Apr 6, 2023
rmnscnce
force-pushed
the
serde
branch
6 times, most recently
from
3dd4e9c
to
297c255
Compare
rmnscnce
force-pushed
the
serde
branch
2 times, most recently
from
9388fbf
to
407d50b
Compare
sdroege
reviewed
Apr 11, 2023
rmnscnce
force-pushed
the
serde
branch
2 times, most recently
from
d222857
to
59b15e0
Compare
rmnscnce
force-pushed
the
serde
branch
3 times, most recently
from
c45eb0b
to
abe5dfd
Compare
rmnscnce
force-pushed
the
serde
branch
5 times, most recently
from
89d0f10
to
e4e7b7f
Compare
sdroege
reviewed
Oct 27, 2023
.github/workflows/CI.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| - { name: "cairo", features: "png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface", nightly: "--features 'png,pdf,svg,ps,use_glib,v1_18,freetype,script,xcb,xlib,win32-surface'", test_sys: true } | |||
| - { name: "gdk-pixbuf", features: "v2_42", nightly: "--all-features", test_sys: true } | |||
| - { name: "gio", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
| - { name: "glib", features: "v2_74", nightly: "--all-features", test_sys: true } | |||
| - { name: "glib", features: "v2_74,serde", nightly: "--all-features", test_sys: true } | |||
There was a problem hiding this comment.
Suggested change
| - { name: "glib", features: "v2_74,serde", nightly: "--all-features", test_sys: true } | |
| - { name: "glib", features: "v2_74", nightly: "--all-features", test_sys: true } | |
| - { name: "glib serde", features: "v2_74,serde", nightly: "--all-features", test_sys: true } |
or so maybe so we test both configurations?
rmnscnce
force-pushed
the
serde
branch
4 times, most recently
from
ea985eb
to
5fd8889
Compare
… serde This feature is gated as `serde` Supports both serialization and deserialization: - glib::ByteArray - glib::Bytes - glib::GString Supports serialization only: - glib::GStr - glib::StrV Collection types are also supported as long as the type parameters implement the necessary traits: - glib::Slice<T: TransparentType + ..> - glib::PtrSlice<T: TransparentPtrType + ..> - glib::List<T: TransparentPtrType + ..> - glib::SList<T: TransparentPtrType + ..>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, some GLib types will gain serialization and deserialization support through the serde serialization framework. This feature is gated as
serdein theglibpackage.Supported types for both deserialization and serialization:
glib::ByteArrayglib::Bytesglib::GStringSome types are only serializable:
glib::GStrglib::StrVCollection types are also supported as long as the type parameters implement the necessary traits:
glib::Slice<T: TransparentType + ..>glib::PtrSlice<T: TransparentPtrType + ..>glib::List<T: TransparentPtrType + ..>glib::SList<T: TransparentPtrType + ..>