Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing atlas to post merge CI #1891

Merged
merged 2 commits into from May 8, 2024
Merged

add missing atlas to post merge CI #1891

merged 2 commits into from May 8, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented May 6, 2024

Description of the PR

Fix main test: add missing atlas to post merge CI

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
add missing atlas to post merge ci
8067a9c 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
fix unused parameter for golang ci lint action
34e2a54 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit 4dc7c94 into guacsec:main May 8, 2024
8 checks passed
@pxp928 pxp928 deleted the fix-atlas-postmerge branch May 8, 2024 20:08
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@pxp928 @arorasoham9
add missing atlas to post merge CI (guacsec#1891)
d25f125 
* add missing atlas to post merge ci

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fix unused parameter for golang ci lint action

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @jeffmendoza